Skip to content

Fix velocities in the nonconservative fluxes #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranocha merged 4 commits into from
Nov 26, 2025
Merged

Fix velocities in the nonconservative fluxes #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b2677d
fix euler with gravity
MarcoArtiano Nov 26, 2025
0a2248f
fmt
MarcoArtiano Nov 26, 2025
34475ec
fix test
MarcoArtiano Nov 26, 2025
a658150
fmt
MarcoArtiano Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions src/equations/compressible_euler_energy_with_gravity_3d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ The well balanced on curvilinear coordinates was proven by
equations::CompressibleEulerEnergyEquationsWithGravity3D)
rho_ll, rho_v1_ll, rho_v2_ll, rho_v3_ll, _, phi_ll = u_ll
rho_rr, rho_v1_rr, rho_v2_rr, rho_v3_rr, _, phi_rr = u_rr
v1_ll = rho_v1_ll
v2_ll = rho_v2_ll
v3_ll = rho_v3_ll
v1_rr = rho_v1_rr
v2_rr = rho_v2_rr
v3_rr = rho_v3_rr
v1_ll = rho_v1_ll / rho_ll
v2_ll = rho_v2_ll / rho_ll
v3_ll = rho_v3_ll / rho_ll
v1_rr = rho_v1_rr / rho_rr
v2_rr = rho_v2_rr / rho_rr
v3_rr = rho_v3_rr / rho_rr
v1_avg = 0.5f0 * (v1_ll + v1_rr)
v2_avg = 0.5f0 * (v2_ll + v2_rr)
v3_avg = 0.5f0 * (v3_ll + v3_rr)
Expand Down Expand Up @@ -174,12 +174,12 @@ Well-balanced gravity term for constant potential temperature background state b
equations::CompressibleEulerEnergyEquationsWithGravity3D)
rho_ll, rho_v1_ll, rho_v2_ll, rho_v3_ll, _, phi_ll = u_ll
rho_rr, rho_v1_rr, rho_v2_rr, rho_v3_rr, _, phi_rr = u_rr
v1_ll = rho_v1_ll
v2_ll = rho_v2_ll
v3_ll = rho_v3_ll
v1_rr = rho_v1_rr
v2_rr = rho_v2_rr
v3_rr = rho_v3_rr
v1_ll = rho_v1_ll / rho_ll
v2_ll = rho_v2_ll / rho_ll
v3_ll = rho_v3_ll / rho_ll
v1_rr = rho_v1_rr / rho_rr
v2_rr = rho_v2_rr / rho_rr
v3_rr = rho_v3_rr / rho_rr
v1_avg = 0.5f0 * (v1_ll + v1_rr)
v2_avg = 0.5f0 * (v2_ll + v2_rr)
v3_avg = 0.5f0 * (v3_ll + v3_rr)
Expand Down Expand Up @@ -208,12 +208,12 @@ end
equations::CompressibleEulerEnergyEquationsWithGravity3D)
rho_ll, rho_v1_ll, rho_v2_ll, rho_v3_ll, _, phi_ll = u_ll
rho_rr, rho_v1_rr, rho_v2_rr, rho_v3_rr, _, phi_rr = u_rr
v1_ll = rho_v1_ll
v2_ll = rho_v2_ll
v3_ll = rho_v3_ll
v1_rr = rho_v1_rr
v2_rr = rho_v2_rr
v3_rr = rho_v3_rr
v1_ll = rho_v1_ll / rho_ll
v2_ll = rho_v2_ll / rho_ll
v3_ll = rho_v3_ll / rho_ll
v1_rr = rho_v1_rr / rho_rr
v2_rr = rho_v2_rr / rho_rr
v3_rr = rho_v3_rr / rho_rr
v1_avg = 0.5f0 * (v1_ll + v1_rr)
v2_avg = 0.5f0 * (v2_ll + v2_rr)
v3_avg = 0.5f0 * (v3_ll + v3_rr)
Expand Down Expand Up @@ -289,8 +289,8 @@ Kinetic energy preserving two-point flux by
@inline function flux_kennedy_gruber(u_ll, u_rr, normal_direction::AbstractVector,
equations::CompressibleEulerEnergyEquationsWithGravity3D)
# Unpack left and right state
rho_e_ll = last(u_ll)
rho_e_rr = last(u_rr)
rho_e_ll = u_ll[5]
rho_e_rr = u_rr[5]
rho_ll, v1_ll, v2_ll, v3_ll, p_ll = cons2prim(u_ll, equations)
rho_rr, v1_rr, v2_rr, v3_rr, p_rr = cons2prim(u_rr, equations)

Expand Down
2 changes: 1 addition & 1 deletion test/test_3d_euler_energy.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ include("test_trixiatmo.jl")
0.024276204894145392,
0.045702372863804186,
0.022711918877967086,
0.9494724421529099,
0.9494724034739193,
0.3119894564151764
], tspan=(0.0, 0.01), tol=1e-15, atol=1e-8)
# Ensure that we do not have excessive memory allocations
Expand Down
Loading