Skip to content

more upstream tests#144

Merged
ranocha merged 4 commits intomainfrom
hr/more_upstream_tests
Feb 4, 2026
Merged

more upstream tests#144
ranocha merged 4 commits intomainfrom
hr/more_upstream_tests

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Feb 4, 2026

@JoshuaLampert noticed that the TrixiAtmo.jl upstream tests did not fail in trixi-framework/Trixi.jl#2775 (review). The reason is that we did not check for warnings and ran only a few tests. Thus, I added additional checks for upstream CI runs.

@ranocha ranocha added the testing label Feb 4, 2026
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. Thanks!

Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the formatter, please?

@ranocha ranocha requested a review from JoshuaLampert February 4, 2026 10:35
JoshuaLampert
JoshuaLampert previously approved these changes Feb 4, 2026
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha ranocha enabled auto-merge (squash) February 4, 2026 10:41
@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Feb 4, 2026

I don't know why exactly it failed before, but the additional upstream tests should be enough, I think.

@ranocha ranocha disabled auto-merge February 4, 2026 11:09
@ranocha ranocha enabled auto-merge (squash) February 4, 2026 11:09
@JoshuaLampert
Copy link
Copy Markdown
Member

I don't know why exactly it failed before, but the additional upstream tests should be enough, I think.

I am not entirely sure, but the issue with the @test_trixi_include could have been the semicolon instead of a comma here and here.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.10%. Comparing base (ec70915) to head (11bc305).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files          33       33           
  Lines        4558     4558           
=======================================
  Hits         4426     4426           
  Misses        132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ranocha ranocha merged commit a24993d into main Feb 4, 2026
10 checks passed
@ranocha ranocha deleted the hr/more_upstream_tests branch February 4, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants