Conversation
…iParticles.jlOpen into hagen_poiseuille_flow
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
===========================================
- Coverage 88.70% 66.95% -21.75%
===========================================
Files 128 128
Lines 9764 9744 -20
===========================================
- Hits 8661 6524 -2137
- Misses 1103 3220 +2117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nd improve simulation parameters
efaulhaber
left a comment
There was a problem hiding this comment.
I guess @LasNikas should take a look here, since you copied his code.
|
That works for me. However, it might be worth mentioning in the 2D and 3D examples that the pressure gradient is defined over the entire inflow-to-outflow extent and that the boundary zones free surfaces start and end at x=0 and x=L, respectively. |
I have added a comment to the setups |
|
/run-gpu-tests |
…iParticles.jlOpen into hagen_poiseuille_flow
|
/run-gpu-tests |
Extracted from #922