Skip to content

Poiseuille flow 3d setup#1075

Open
svchb wants to merge 29 commits intotrixi-framework:mainfrom
svchb:hagen_poiseuille_flow
Open

Poiseuille flow 3d setup#1075
svchb wants to merge 29 commits intotrixi-framework:mainfrom
svchb:hagen_poiseuille_flow

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented Feb 24, 2026

Extracted from #922

@svchb svchb marked this pull request as draft February 24, 2026 11:51
@svchb svchb self-assigned this Feb 24, 2026
@svchb svchb added the enhancement New feature or request label Feb 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.95%. Comparing base (3a5900a) to head (b0e2ede).

❗ There is a different number of reports uploaded between BASE (3a5900a) and HEAD (b0e2ede). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3a5900a) HEAD (b0e2ede)
total 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1075       +/-   ##
===========================================
- Coverage   88.70%   66.95%   -21.75%     
===========================================
  Files         128      128               
  Lines        9764     9744       -20     
===========================================
- Hits         8661     6524     -2137     
- Misses       1103     3220     +2117     
Flag Coverage Δ
total ?
unit 66.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb marked this pull request as ready for review February 24, 2026 13:35
@svchb svchb requested review from LasNikas and efaulhaber February 24, 2026 13:36
Copy link
Copy Markdown
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @LasNikas should take a look here, since you copied his code.

@svchb svchb requested a review from efaulhaber April 8, 2026 13:14
efaulhaber
efaulhaber previously approved these changes Apr 9, 2026
@LasNikas
Copy link
Copy Markdown
Collaborator

LasNikas commented Apr 9, 2026

That works for me. However, it might be worth mentioning in the 2D and 3D examples that the pressure gradient is defined over the entire inflow-to-outflow extent and that the boundary zones free surfaces start and end at x=0 and x=L, respectively.
This means that the boundary zones are effectively part of the computational domain.
Otherwise, this could cause confusion during the validation process.

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Apr 13, 2026

That works for me. However, it might be worth mentioning in the 2D and 3D examples that the pressure gradient is defined over the entire inflow-to-outflow extent and that the boundary zones free surfaces start and end at x=0 and x=L, respectively.
This means that the boundary zones are effectively part of the computational domain.
Otherwise, this could cause confusion during the validation process.

I have added a comment to the setups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants