Deactivate out of bounds particle

[LasNikas]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.16%. Comparing base (a3f1139) to head (92bbc66).

Files with missing lines	Patch %	Lines
src/general/neighborhood_search.jl	81.25%	3 Missing ⚠️
test/general/neighborhood_search.jl	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   89.17%   89.16%   -0.02%     
==========================================
  Files         128      129       +1     
  Lines        9925     9950      +25     
==========================================
+ Hits         8851     8872      +21     
- Misses       1074     1078       +4     

Flag	Coverage Δ
total	89.16% <84.00%> (-0.02%)	⬇️
unit	67.60% <64.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[svchb]

PR 1000 🎉🔥

[LasNikas]

Any thoughts on this, @efaulhaber and @svchb ? I can't think of anything better at the moment. However, I can't see any reason why we shouldn't have this (except for performance, but I think that's negligible?)

[LasNikas]

/run-gpu-tests

[svchb]

Any thoughts on this, @efaulhaber and @svchb ? I can't think of anything better at the moment. However, I can't see any reason why we shouldn't have this (except for performance, but I think that's negligible?)

I think it should be optional. Otherwise I am fine with this.

[LasNikas]

I think it should be optional. Otherwise I am fine with this.

I also considered making this optional. However, it would then be necessary to explain that this can only be set if a full grid cell list and a system buffer are used. Users should not expect this to apply to other constellations. This would need to be explained in more detail. Should I do that? @svchb @efaulhaber

[svchb]

I think it should be optional. Otherwise I am fine with this.

I also considered making this optional. However, it would then be necessary to explain that this can only be set if a full grid cell list and a system buffer are used. Users should not expect this to apply to other constellations. This would need to be explained in more detail. Should I do that? @svchb @efaulhaber

You could of course implement this for the other nhs types as well.

[LasNikas]

You could of course implement this for the other nhs types as well.

But the domain is potentially infinite for the other NHS. Also, it only works with system buffer, as the particles are not deleted but only deactivated.

[svchb]

You could of course implement this for the other nhs types as well.

But the domain is potentially infinite for the other NHS. Also, it only works with system buffer, as the particles are not deleted but only deactivated.

Hmm... You could throw an error message if its activated for other nhs types.

[efaulhaber]

Tests are failing.

[efaulhaber]

Please add more comments explaining why this is done and when. Something like "the full grid cell list requires a bounding box. For this cell list, we deactivate particles that are outside the bounding box. These particles are glitched out of the open boundary and don't contribute anyway, and would crash the simulation if they move outside the bounding box and are not removed.