Make density diffusion in open boundaries settable#1043
Merged
LasNikas merged 18 commits intotrixi-framework:mainfrom Apr 10, 2026
Merged
Make density diffusion in open boundaries settable#1043LasNikas merged 18 commits intotrixi-framework:mainfrom
LasNikas merged 18 commits intotrixi-framework:mainfrom
Conversation
Collaborator
Author
|
/run-gpu-tests |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 88.70% 88.71%
=======================================
Files 128 128
Lines 9746 9752 +6
=======================================
+ Hits 8645 8651 +6
Misses 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svchb
requested changes
Jan 19, 2026
efaulhaber
requested changes
Feb 27, 2026
added 2 commits
February 27, 2026 16:28
LasNikas
force-pushed
the
open-boundary-ddt
branch
from
c426f9c to
c8125bb
Compare
efaulhaber
requested changes
Mar 2, 2026
Member
efaulhaber
left a comment
efaulhaber
left a comment
There was a problem hiding this comment.
Please don't force-push on a PR that is in review. This breaks the "changes since last review" feature (among other things).
added 2 commits
March 9, 2026 15:18
svchb
previously approved these changes
Mar 19, 2026
efaulhaber
requested changes
Mar 25, 2026
efaulhaber
approved these changes
Apr 10, 2026
Collaborator
Author
|
/run-gpu-tests |
Member
|
/run-gpu-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On main, the density diffusion is taken from the fluid system and cannot be set.
With this PR, one can take density diffusion independent of the fluid.
In addition, the same method of
continuity_equation!is now called as for theAbstractFluidSystem(I only had to copy the method because of the include order).
It also fixes a bug with the
v_maxcalculation forParticleShiftingTechnique.Closes #1072.