Conversation
…nitialCondition` (#959) * Update vtk2trixi function to return `NamedTuple` instead of `InitialCondition` * Refactor vtk2trixi function to accept custom fields * Enhance vtk2trixi function to support scalar and vector custom quantities and update tests * Fix typo in documentation for vtk2trixi function * Fix capitalization in comments * Fix formatting in documentation * Corrected failing doctest output * Corrected failing doctest output * add NEWS entry * revise * fix doc test * fix NEWS entry * fix merge bug * load `custom_quantities` automatically * implement suggestions * fix jldoctest * Add `create_initial_condition` parameter --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> Co-authored-by: Sven Berger <berger.sven@gmail.com> Co-authored-by: LasNikas <niklas.nehe@web.de> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
Member
|
I fixed the broken tests in #1142. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
==========================================
+ Coverage 89.17% 89.22% +0.04%
==========================================
Files 128 127 -1
Lines 9925 9980 +55
==========================================
+ Hits 8851 8905 +54
- Misses 1074 1075 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vtk2trixiso that it returns aNamedTupleinstead of anInitialCondition#959DensityDiffusionAntuono#1142n_clamped_particles#964