Skip to content

support scimlbase 3#1171

Open
svchb wants to merge 4 commits into
trixi-framework:mainfrom
svchb:scimlbase3
Open

support scimlbase 3#1171
svchb wants to merge 4 commits into
trixi-framework:mainfrom
svchb:scimlbase3

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented Apr 30, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.51%. Comparing base (7e43937) to head (ad884cc).

Files with missing lines Patch % Lines
src/callbacks/split_integration.jl 0.00% 2 Missing ⚠️
src/preprocessing/particle_packing/system.jl 0.00% 2 Missing ⚠️
test/callbacks/info.jl 0.00% 2 Missing ⚠️
src/callbacks/mechanical_work_calculator.jl 0.00% 1 Missing ⚠️
src/callbacks/post_process.jl 0.00% 1 Missing ⚠️
src/callbacks/stepsize.jl 0.00% 1 Missing ⚠️
src/callbacks/update.jl 0.00% 1 Missing ⚠️
src/io/io.jl 0.00% 1 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl 0.00% 1 Missing ⚠️
src/schemes/fluid/shifting_techniques.jl 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files         132      132           
  Lines       10413    10413           
=======================================
  Hits         7343     7343           
  Misses       3070     3070           
Flag Coverage Δ
unit 70.51% <17.64%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Apr 30, 2026

/run-gpu-tests

@svchb svchb requested a review from efaulhaber April 30, 2026 12:22
@svchb svchb self-assigned this Apr 30, 2026
@svchb svchb added the dependencies Pull requests that update a dependency file label Apr 30, 2026
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 4, 2026

/run-gpu-tests

@efaulhaber
Copy link
Copy Markdown
Member

This PR breaks compatibility with all old versions. Do we want that? Trixi.jl keeps backwards compatibility:
https://github.com/trixi-framework/Trixi.jl/pull/2996/changes

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 7, 2026

This PR breaks compatibility with all old versions. Do we want that? Trixi.jl keeps backwards compatibility: https://github.com/trixi-framework/Trixi.jl/pull/2996/changes

yes but they don't actually test the old stack. I tried with an older version before and than it just broke because of the dependencies that are too wide in the sciml world.

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 7, 2026

So if we want to have compatability with the older sciml stack we would also need to add a test in my opinion for that.

@efaulhaber
Copy link
Copy Markdown
Member

That is a good point. I guess since we're not as big as Trixi, we can simply drop support for the old versions. @sloede what do you say is the best approach here?

svchb added 2 commits May 12, 2026 11:12
# Conflicts:
#	Project.toml
#	src/callbacks/sorting.jl
#	src/callbacks/split_integration.jl
#	test/Project.toml
#	test/examples/examples_fluid.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants