support scimlbase 3#1171
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 70.51% 70.51%
=======================================
Files 132 132
Lines 10413 10413
=======================================
Hits 7343 7343
Misses 3070 3070
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/run-gpu-tests |
|
/run-gpu-tests |
|
This PR breaks compatibility with all old versions. Do we want that? Trixi.jl keeps backwards compatibility: |
yes but they don't actually test the old stack. I tried with an older version before and than it just broke because of the dependencies that are too wide in the sciml world. |
|
So if we want to have compatability with the older sciml stack we would also need to add a test in my opinion for that. |
|
That is a good point. I guess since we're not as big as Trixi, we can simply drop support for the old versions. @sloede what do you say is the best approach here? |
# Conflicts: # Project.toml # src/callbacks/sorting.jl # src/callbacks/split_integration.jl # test/Project.toml # test/examples/examples_fluid.jl
No description provided.