[codex] Fix density reinitialization callback#1181
Open
svchb wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
+ Coverage 89.92% 89.95% +0.02%
==========================================
Files 132 133 +1
Lines 10434 10449 +15
==========================================
+ Hits 9383 9399 +16
+ Misses 1051 1050 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
requested changes
May 12, 2026
Member
efaulhaber
left a comment
There was a problem hiding this comment.
Doesn't work because the system might be replaced in the semidiscretization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DensityReinitializationCallbackand reinitialize only that systemdt-based reinitialization when the requested interval is reached, not only after it is exceededdttriggering, and selected-system reinitializationRoot Cause
The callback constructor accepted a specific particle system, but the affect path called the global
reinit_density!(vu_ode, semi)helper, which loops over every system in the semidiscretization. The time-based condition also used a strict>comparison, delaying callbacks that land exactly on the configured interval.Validation
julia --project=. -e 'using Test, TrixiParticles; include("test/callbacks/density_reinit.jl")'\n-julia --project=. -e 'using Test, TrixiParticles, Printf; include("test/callbacks/callbacks.jl")'