Fix interpolated wall velocity with cut_off_bnd=false#1185
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect interpolation of boundary wall velocity when include_wall_velocity=true is used together with cut_off_bnd=false, ensuring boundary contributions are considered even when the cutoff logic is disabled.
Changes:
- Update interpolation system iteration logic to include boundary systems when
include_wall_velocity=true, even ifcut_off_bnd=false. - Add 2D and 3D regression tests for
include_wall_velocity=truewithcut_off_bnd=falseat the wall point.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/general/interpolation.jl |
Adjusts which systems are iterated during interpolation to include boundary systems when wall velocity is requested. |
test/general/interpolation.jl |
Adds regression assertions for interpolated wall velocity with cut_off_bnd=false in both 2D and 3D testsets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1185 +/- ##
=======================================
Coverage 70.51% 70.52%
=======================================
Files 132 132
Lines 10413 10414 +1
=======================================
+ Hits 7343 7344 +1
Misses 3070 3070
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I fixed this before somewhere, but I forgot where and can't find it anymore. Maybe in one of my old fin prototyping branches?