Skip to content

Fix interpolated wall velocity with cut_off_bnd=false#1185

Open
efaulhaber wants to merge 3 commits into
trixi-framework:mainfrom
efaulhaber:fix-interpolation-wall-velocity
Open

Fix interpolated wall velocity with cut_off_bnd=false#1185
efaulhaber wants to merge 3 commits into
trixi-framework:mainfrom
efaulhaber:fix-interpolation-wall-velocity

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

I fixed this before somewhere, but I forgot where and can't find it anymore. Maybe in one of my old fin prototyping branches?

@efaulhaber efaulhaber self-assigned this May 12, 2026
@efaulhaber efaulhaber requested review from Copilot and svchb May 12, 2026 09:53
@efaulhaber efaulhaber added the bug Something isn't working label May 12, 2026
svchb
svchb previously approved these changes May 12, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses incorrect interpolation of boundary wall velocity when include_wall_velocity=true is used together with cut_off_bnd=false, ensuring boundary contributions are considered even when the cutoff logic is disabled.

Changes:

  • Update interpolation system iteration logic to include boundary systems when include_wall_velocity=true, even if cut_off_bnd=false.
  • Add 2D and 3D regression tests for include_wall_velocity=true with cut_off_bnd=false at the wall point.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/general/interpolation.jl Adjusts which systems are iterated during interpolation to include boundary systems when wall velocity is requested.
test/general/interpolation.jl Adds regression assertions for interpolated wall velocity with cut_off_bnd=false in both 2D and 3D testsets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/general/interpolation.jl
Comment thread test/general/interpolation.jl
Comment thread test/general/interpolation.jl
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.52%. Comparing base (7e43937) to head (70c9408).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   70.51%   70.52%           
=======================================
  Files         132      132           
  Lines       10413    10414    +1     
=======================================
+ Hits         7343     7344    +1     
  Misses       3070     3070           
Flag Coverage Δ
unit 70.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants