Implement Implicit Incompressible SPH (IISPH)#751
Merged
svchb merged 97 commits intotrixi-framework:mainfrom Sep 24, 2025
Merged
Implement Implicit Incompressible SPH (IISPH)#751svchb merged 97 commits intotrixi-framework:mainfrom
svchb merged 97 commits intotrixi-framework:mainfrom
Conversation
efaulhaber
requested changes
Apr 7, 2025
efaulhaber
requested changes
May 22, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 67.84% 66.18% -1.67%
==========================================
Files 110 113 +3
Lines 7558 7824 +266
==========================================
+ Hits 5128 5178 +50
- Misses 2430 2646 +216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
requested changes
May 28, 2025
Member
efaulhaber
left a comment
efaulhaber
left a comment
There was a problem hiding this comment.
I haven't looked at the docs and system.jl yet. I will do that in the next review to keep the reviews small. Please first incorporate these changes.
Also, please resolve open conversations after implementing the changes.
Member
|
Please resolve conversations after implementing the changes. And please fix the tests. |
svchb
reviewed
Sep 19, 2025
svchb
requested changes
Sep 19, 2025
the viscosity model
smoothing kernel and length
LasNikas
reviewed
Sep 21, 2025
efaulhaber
requested changes
Sep 22, 2025
efaulhaber
reviewed
Sep 22, 2025
efaulhaber
changed the title
efaulhaber
approved these changes
Sep 23, 2025
Member
|
/run-gpu-tests |
efaulhaber
requested changes
Sep 23, 2025
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
efaulhaber
approved these changes
Sep 23, 2025
Member
|
/run-gpu-tests |
LasNikas
approved these changes
Sep 24, 2025
svchb
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.