Add simple SGS to Adami and Morris Viscosity#753
Merged
svchb merged 45 commits intotrixi-framework:mainfrom Jun 13, 2025
Merged
Add simple SGS to Adami and Morris Viscosity#753svchb merged 45 commits intotrixi-framework:mainfrom
svchb merged 45 commits intotrixi-framework:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
==========================================
+ Coverage 70.12% 70.51% +0.39%
==========================================
Files 106 106
Lines 6822 6865 +43
==========================================
+ Hits 4784 4841 +57
+ Misses 2038 2024 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LasNikas
requested changes
May 13, 2025
LasNikas
reviewed
May 14, 2025
efaulhaber
requested changes
May 23, 2025
efaulhaber
previously approved these changes
May 28, 2025
efaulhaber
previously approved these changes
May 28, 2025
LasNikas
previously approved these changes
Jun 12, 2025
Collaborator
Author
|
/run-gpu-tests |
Collaborator
Author
|
/run-gpu-tests |
efaulhaber
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TGV:
This shows the default values give reasonable results
With C_S=0.5:
