Skip to content

Improve plane interpolation performance#763

Merged
svchb merged 15 commits intotrixi-framework:mainfrom
efaulhaber:interpolation-performance
May 13, 2025
Merged

Improve plane interpolation performance#763
svchb merged 15 commits intotrixi-framework:mainfrom
efaulhaber:interpolation-performance

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

@efaulhaber efaulhaber commented Apr 10, 2025

Depends on #755 and trixi-framework/PointNeighbors.jl#105.

main:

apply postprocess cb                10     256s   88.5%   25.6s   89.5GiB   99.8%  8.95GiB
  ~apply postprocess cb~            10     256s   88.4%   25.6s   89.5GiB   99.8%  8.95GiB
  update systems                    10    159ms    0.1%  15.9ms   56.2KiB    0.0%  5.62KiB

#755:

apply postprocess cb                10    64.4s   62.3%   6.44s   89.3GiB   99.7%  8.93GiB
  ~apply postprocess cb~            10    64.2s   62.1%   6.42s   89.3GiB   99.7%  8.93GiB
  update systems                    10    167ms    0.2%  16.7ms   56.2KiB    0.0%  5.62KiB

this PR:

apply postprocess cb                10    2.22s    3.6%   222ms    305MiB   58.9%  30.5MiB
  write to vtk                      10    1.44s    2.3%   144ms   85.0MiB   16.4%  8.50MiB
  interpolate plane                 10    617ms    1.0%  61.7ms    220MiB   42.5%  22.0MiB
  update systems                    10    162ms    0.3%  16.2ms   56.2KiB    0.0%  5.62KiB

@efaulhaber efaulhaber self-assigned this Apr 10, 2025
@efaulhaber efaulhaber force-pushed the interpolation-performance branch from 41bba45 to 22ccc41 Compare April 12, 2025 09:35
@efaulhaber efaulhaber force-pushed the interpolation-performance branch from 22ccc41 to ad37459 Compare April 16, 2025 14:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 83.70370% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (5e219e4) to head (718b0cb).

Files with missing lines Patch % Lines
src/general/interpolation.jl 78.43% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   70.61%   70.58%   -0.04%     
==========================================
  Files         105      105              
  Lines        6667     6649      -18     
==========================================
- Hits         4708     4693      -15     
+ Misses       1959     1956       -3     
Flag Coverage Δ
unit 70.58% <83.70%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efaulhaber efaulhaber marked this pull request as ready for review April 23, 2025 20:20
@efaulhaber efaulhaber requested review from LasNikas, Copilot and svchb and removed request for Copilot and svchb April 23, 2025 20:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • examples/postprocessing/interpolation_plane.jl: Language not supported
  • examples/postprocessing/interpolation_point_line.jl: Language not supported
  • src/TrixiParticles.jl: Language not supported
  • src/general/interpolation.jl: Language not supported
  • test/examples/examples.jl: Language not supported

@efaulhaber efaulhaber requested a review from svchb April 23, 2025 20:20
Comment thread test/examples/examples.jl Outdated
@efaulhaber efaulhaber requested a review from LasNikas April 24, 2025 09:09
Comment thread test/general/interpolation.jl
Comment thread test/general/interpolation.jl
Comment thread src/general/interpolation.jl
@efaulhaber
Copy link
Copy Markdown
Member Author

/run-gpu-tests

@efaulhaber efaulhaber requested review from LasNikas and svchb May 12, 2025 17:16
svchb
svchb approved these changes May 12, 2025
@svchb svchb merged commit a6a520f into trixi-framework:main May 13, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants