Skip to content

Validate open boundaries#781

Open
LasNikas wants to merge 58 commits intotrixi-framework:mainfrom
LasNikas:validate-open-boundaries
Open

Validate open boundaries#781
LasNikas wants to merge 58 commits intotrixi-framework:mainfrom
LasNikas:validate-open-boundaries

Conversation

@LasNikas
Copy link
Copy Markdown
Collaborator

@LasNikas LasNikas commented Apr 25, 2025

Comparison of the Mirroring and Dynamical Pressure Models

Tafuni et al. (2018)

d / 100 (St = 0.206)
image

BoundaryModelMirroringTafuni

PST

shifting_technique = ParticleShiftingTechnique(; sound_speed_factor=0.1, v_max_factor=0)
d / 12.5 d / 25 d / 50
image image image

TVF

shifting_technique = TransportVelocityAdami(background_pressure=5 * fluid_density * sound_speed^2)
d / 12.5 d / 25 d / 50
image image image

BoundaryModelDynamicalPressureZhang

PST

shifting_technique = ParticleShiftingTechnique(; sound_speed_factor=0.1, v_max_factor=0)
d / 12.5 d / 25 d / 50
image image image

TVF

shifting_technique = TransportVelocityAdami(background_pressure=5 * fluid_density * sound_speed^2)
d / 12.5 d / 25 d / 50
image image image

@LasNikas LasNikas requested review from efaulhaber and svchb May 17, 2025 10:08
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.79%. Comparing base (08ecf7f) to head (2e2725d).
⚠️ Report is 46 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (08ecf7f) and HEAD (2e2725d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ecf7f) HEAD (2e2725d)
total 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #781       +/-   ##
===========================================
- Coverage   89.58%   64.79%   -24.79%     
===========================================
  Files         120      120               
  Lines        8628     8606       -22     
===========================================
- Hits         7729     5576     -2153     
- Misses        899     3030     +2131     
Flag Coverage Δ
total ?
unit 64.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@svchb svchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither the validation or the examples are included in the CI runs.

@LasNikas LasNikas force-pushed the validate-open-boundaries branch from f7826d7 to 16c4f71 Compare October 22, 2025 17:45
@svchb svchb self-requested a review December 4, 2025 12:27
@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Dec 8, 2025

The testing in the CI is pointless at this high resolution. This short-amount of time will not yield anything.
The resolution has to be further reduced for CI testing.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Dec 8, 2025

The example is also running too long.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Dec 8, 2025

I have reduced the runtime of both the validation case and example.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Dec 10, 2025

Interpolation seems to be broken see #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants