Skip to content

Fix error message when using TVF without UpdateCB#807

Merged
svchb merged 5 commits intotrixi-framework:mainfrom
svchb:fix-error-for-TVF
May 22, 2025
Merged

Fix error message when using TVF without UpdateCB#807
svchb merged 5 commits intotrixi-framework:mainfrom
svchb:fix-error-for-TVF

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented May 14, 2025

Fix #767

@svchb svchb requested review from LasNikas and efaulhaber May 14, 2025 14:16
@svchb svchb self-assigned this May 14, 2025
@svchb svchb added the bug Something isn't working label May 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.72%. Comparing base (cf1a67e) to head (a15eb59).

Files with missing lines Patch % Lines
...rc/schemes/fluid/entropically_damped_sph/system.jl 0.00% 1 Missing ⚠️
src/schemes/fluid/transport_velocity.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   70.68%   70.72%   +0.04%     
==========================================
  Files         106      106              
  Lines        6703     6703              
==========================================
+ Hits         4738     4741       +3     
+ Misses       1965     1962       -3     
Flag Coverage Δ
unit 70.72% <50.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LasNikas
Copy link
Copy Markdown
Collaborator

we solved this for the open boundaries as follows:

function reset_callback_flag!(system::OpenBoundarySPHSystem)

It would be nice if we also do so here

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 15, 2025

It is?

LasNikas
LasNikas previously approved these changes May 19, 2025
Comment thread src/schemes/fluid/entropically_damped_sph/system.jl Outdated
Comment thread src/schemes/fluid/weakly_compressible_sph/system.jl Outdated
Comment thread src/schemes/fluid/transport_velocity.jl
Comment thread src/schemes/fluid/entropically_damped_sph/system.jl
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 22, 2025

/run-gpu-tests

@svchb svchb merged commit d4f8af7 into trixi-framework:main May 22, 2025
15 of 18 checks passed
@svchb svchb deleted the fix-error-for-TVF branch May 22, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No error is thrown when using TVF without UpdateCallback

3 participants