Skip to content

Separate computed and interpolated density in interpolation#808

Merged
efaulhaber merged 8 commits intotrixi-framework:mainfrom
LasNikas:fix-interpolation
May 18, 2025
Merged

Separate computed and interpolated density in interpolation#808
efaulhaber merged 8 commits intotrixi-framework:mainfrom
LasNikas:fix-interpolation

Conversation

@LasNikas
Copy link
Copy Markdown
Collaborator

@LasNikas LasNikas commented May 15, 2025

See discussion #796 for more details.

@LasNikas LasNikas changed the title Interpolation with inverse distance weighting (Shepard's method) Eliminate `current_density´ from interpolation May 15, 2025
@LasNikas LasNikas changed the title Eliminate `current_density´ from interpolation Eliminate current_density from interpolation May 15, 2025
@LasNikas LasNikas marked this pull request as ready for review May 15, 2025 12:09
@LasNikas LasNikas requested review from efaulhaber and svchb May 15, 2025 12:09
@LasNikas LasNikas self-assigned this May 15, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.70%. Comparing base (8ea6e7f) to head (53a53ec).

Files with missing lines Patch % Lines
src/general/interpolation.jl 80.95% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   70.69%   70.70%           
=======================================
  Files         106      106           
  Lines        6699     6701    +2     
=======================================
+ Hits         4736     4738    +2     
  Misses       1963     1963           
Flag Coverage Δ
unit 70.70% <80.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LasNikas LasNikas changed the title Eliminate current_density from interpolation Separate computed and interpolated density in interpolation May 15, 2025
Comment thread src/general/interpolation.jl Outdated
Comment thread src/general/interpolation.jl Outdated
@LasNikas LasNikas requested a review from efaulhaber May 15, 2025 15:58
@LasNikas
Copy link
Copy Markdown
Collaborator Author

\run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented May 16, 2025

/run-gpu-tests

@efaulhaber efaulhaber merged commit 13694fc into trixi-framework:main May 18, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants