Automatic ordering of clamped particles#931
Merged
LasNikas merged 29 commits intotrixi-framework:mainfrom Oct 31, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
+ Coverage 63.87% 63.89% +0.02%
==========================================
Files 117 117
Lines 7842 7858 +16
==========================================
+ Hits 5009 5021 +12
- Misses 2833 2837 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svchb
requested changes
Oct 2, 2025
Collaborator
svchb
left a comment
There was a problem hiding this comment.
A test is missing.
If you remove the first option it is a breaking change.
added 4 commits
October 6, 2025 12:10
19 tasks
122e5ef to
88b09e3
Compare
Collaborator
Author
|
/run-gpu-tests |
efaulhaber
requested changes
Oct 28, 2025
efaulhaber
requested changes
Oct 30, 2025
efaulhaber
requested changes
Oct 30, 2025
added 2 commits
October 31, 2025 09:54
efaulhaber
requested changes
Oct 31, 2025
Collaborator
Author
|
/run-gpu-tests |
efaulhaber
approved these changes
Oct 31, 2025
svchb
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, we now have two ways to specify clamped particles:
n_clamped_particles,ensuring that these particles are the last entries in the
InitialConditionclamped_particles.In this case, the specified particles will be internally reordered so that they become
the last particles in the
InitialCondition.The second option can be helpful in more complex setups, for example, to avoid
unions.Here a snippet from the
oscillating_beam_2d.jlexample