Add macOS support#298
Open
tristanmontoya wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 25 25
Lines 1260 1260
Branches 74 74
=======================================
Hits 1211 1211
Misses 45 45
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Nice to see you here @tristanmontoya ! Thanks for trying and sharing you recipe. In fact, running t8code on macOS is of great interest as well. So, did it everything work for you so far. I think it would be nice to integrate macos support! |
sloede
requested changes
Jun 10, 2026
| ### Prerequisites | ||
|
|
||
| Currently, libtrixi is only developed and tested for Linux. Furthermore, the following | ||
| Currently, libtrixi is developed and tested for Linux and macOS. Furthermore, the following |
Member
There was a problem hiding this comment.
Suggested change
| Currently, libtrixi is developed and tested for Linux and macOS. Furthermore, the following | |
| Currently, libtrixi is developed and tested for Linux and (experimentally) for macOS. Furthermore, the following |
| next to the t8code library. (default: '\$(dirname \$T8CODE_LIBRARY)/ | ||
| libp4est.so') | ||
| 'path/to/libp4est.so' or 'path/to/libp4est.dylib'. If omitted, it | ||
| will be assumed to be located next to the t8code library. |
| to the t8code library. (default: '\$(dirname \$T8CODE_LIBRARY)/ | ||
| libsc.so') | ||
| 'path/to/libsc.so' or 'path/to/libsc.dylib'. If omitted, it will be | ||
| assumed to be located next to the t8code library. |
Comment on lines
+74
to
+76
| if: >- | ||
| github.event_name != 'pull_request' || | ||
| github.event.pull_request.head.repo.full_name == github.repository |
Member
There was a problem hiding this comment.
This is to prevent deploying from PRs?
| ### Prerequisites | ||
|
|
||
| Currently, libtrixi is only developed and tested for Linux. Furthermore, the following | ||
| Currently, libtrixi is developed and tested for Linux and macOS. Furthermore, the following |
Member
There was a problem hiding this comment.
Suggested change
| Currently, libtrixi is developed and tested for Linux and macOS. Furthermore, the following | |
| Currently, libtrixi is developed and tested for Linux and (experimentally) for macOS. Furthermore, the following |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to use libtrixi on my Mac, so with the help of Codex, I got it to work cross-platform and added a small macOS test workflow.