feat: add --project-dir option to create command#12
Merged
trisdoan merged 3 commits intotrobz:mainfrom Feb 26, 2026
Merged
Conversation
5 tasks
Contributor
|
waiting for trobz/odoo-addons-path#7 |
…sion Uses odoo-addons-path to detect codebase layout and infer --addons-path, --odoo-dir, --python-version, and --preset=project from a project directory. ODOO_VERSION becomes optional when --project-dir is provided, as it is read from odoo/release.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hailangvn
force-pushed
the
project_dir
branch
from
54b84b2 to
1452535
Compare
Forge ID: F#T67239
hailangvn
force-pushed
the
project_dir
branch
from
1452535 to
5a4cb9f
Compare
Collaborator
|
Hi anh @hailangvn , thanks for the work. I just added a few improvements
Cool with it? |
…Error detected_paths was only assigned inside an `if project_dir_value` block but referenced outside it, risking a NameError. Extract detection logic into _detect_project_layout() and _resolve_odoo_dir_and_version() helpers, which also reduces create() complexity enough to remove noqa: C901.
hailangvn
force-pushed
the
project_dir
branch
from
63d8e48 to
4184ac7
Compare
Collaborator
Author
|
Thanks @trisdoan for the fix. I have just moved code around to group relevant code together. |
trisdoan
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--project-diroption that usesodoo-addons-pathto auto-detect--addons-path,--odoo-dir, and--preset=projectODOO_VERSIONoptional when--project-diris used — inferred fromodoo/release.pyodoo-addons-pathas a dependencyUsage
Test plan
odoo-venv create --project-dir /path/to/project --dry-run— auto-detects everythingodoo-venv create 18.0 --project-dir /path --dry-run— explicit version takes precedenceodoo-venv create --preset local --project-dir /path --dry-run— explicit preset takes precedenceodoo-venv create --dry-run— errors with clear message about missing ODOO_VERSIONodoo-venv create 18.0 --dry-run— existing behavior unchanged🤖 Generated with Claude Code