feat: prioritize extra requirements#8
Closed
hailangvn wants to merge 1 commit intotrobz:mainfrom
Closed
Conversation
Odoo 13.0 requires vatnumber==1.2.0 that still needs use_2to3. Meanwhile [setuptools>=58.0.0 breaks support for use_2to3](https://stackoverflow.com/questions/69100275/error-while-downloading-the-requirements-using-pip-install-setup-command-use-2) so we need to fall back to setuptools<58.0.0. This commit prioritizes installing extra requirements to support that.
hailangvn
force-pushed
the
imp-prioritize-extra-req
branch
from
7c94318 to
341984f
Compare
Contributor
|
I agree that we should install requirements first (pinned versions) before installing odoo (that depends on non-pinned versions), it will save some bandwidth/time can you please update the commit to focus on that change? then we'll continue on the vatnumber topic in another PR |
Contributor
|
followed up in #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odoo 13.0 requires vatnumber==1.2.0 that still needs use_2to3. Meanwhile setuptools>=58.0.0 breaks support for
use_2to3 so we need to fall back to setuptools<58.0.0. This commit prioritizes installing extra requirements to support that.