Skip to content

Add moon clock with 30-phase local images#474

Merged
tavdog merged 7 commits intotronbyt:mainfrom
markgreinke:main
Apr 29, 2026
Merged

Add moon clock with 30-phase local images#474
tavdog merged 7 commits intotronbyt:mainfrom
markgreinke:main

Conversation

@markgreinke
Copy link
Copy Markdown
Contributor

This code attempts to determine actually gps coordinates automatically. This will display an image representing the current phase of the moon from your location, will show current location time (green between sunrise and sunset and red between sunset and sunrise). It displays the % of the moon illuminated as well and the next full and new moons.

@markgreinke markgreinke requested a review from tavdog as a code owner April 27, 2026 18:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Moon Clock app, which displays the current moon phase, illumination percentage, and dates for the next full and new moons. Feedback includes correcting the manifest filename and a typo in the summary, addressing unexplained logic in the lunar cycle calculation (specifically the 12-hour subtraction and future reference timestamp), improving code organization by moving asset loading to a separate file, and using math.pi for better precision.

Comment thread apps/moon_clock/manifest,yaml
Comment thread apps/moon_clock/moon_clock.star Outdated
Comment thread apps/moon_clock/manifest,yaml Outdated
Comment thread apps/moon_clock/moon_clock.star Outdated
Comment thread apps/moon_clock/moon_clock.star Outdated
Comment thread apps/moon_clock/moon_clock.star Outdated
Copy link
Copy Markdown
Member

@tavdog tavdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix that manifest filename typo and mooone typo.

@tavdog
Copy link
Copy Markdown
Member

tavdog commented Apr 27, 2026

here's the error :
✖ apps/moon_clock
▪️ Problem: manifest didn't validate: app summaries need to be less than 32 characters
annoying I know but best to just fix it. ;)

@markgreinke
Copy link
Copy Markdown
Contributor Author

Think I addressed all fixes

@tavdog tavdog merged commit cfb2eae into tronbyt:main Apr 29, 2026
1 check passed
@tavdog
Copy link
Copy Markdown
Member

tavdog commented Apr 29, 2026

noice job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants