Skip to content

feat: new app steamsales#476

Open
noahpodgurski wants to merge 6 commits intotronbyt:mainfrom
noahpodgurski:steamsales
Open

feat: new app steamsales#476
noahpodgurski wants to merge 6 commits intotronbyt:mainfrom
noahpodgurski:steamsales

Conversation

@noahpodgurski
Copy link
Copy Markdown
Contributor

What's new

  • Add new app steamsales
  • Shows your steam game's new sales and wishlists for today
  • Requires appid and Steam Partner API Key which can be created at https://partner.steamgames.com//pub/groups Create Financial API Group

Co-authored-by: Copilot <copilot@github.com>
@noahpodgurski noahpodgurski requested a review from tavdog as a code owner April 30, 2026 01:59
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Steam Sales app, which displays sales and wishlist data for a specific Steam game. Several issues were identified, including an incorrect date formatting reference string and a runtime error caused by using an undefined variable in an error state. Feedback also includes correcting a UI typo, removing debug prints and commented-out code, implementing HTTP caching for performance, and marking the API key as a secret in the configuration schema to adhere to style guidelines.

Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star Outdated
Comment thread apps/steamsales/steamsales.star
noahpodgurski and others added 4 commits April 29, 2026 22:02
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant