Openweather app submission#488
Merged
tavdog merged 3 commits intotronbyt:mainfrom May 6, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the OpenWeather Forecast app. The manifest requires a unique UUID, the packageName attribute, and a version string consistent with the script. A .webp preview image must be added to the app directory. The Starlark script should use HTTPS for geocoding requests and set secret = True for the API key configuration field.
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| id: a1b2c3d4-e5f6-7890-abcd-ef1234567890 | |||
Contributor
There was a problem hiding this comment.
Placeholder ID detected. Use a unique UUID.
| id: a1b2c3d4-e5f6-7890-abcd-ef1234567890 | ||
| name: OpenWeather Forecast | ||
| summary: 3-Day Weather Forecast | ||
| desc: V0.1 Display 3-day weather forecast using OpenWeather One Call API 3.0. |
Contributor
There was a problem hiding this comment.
Version mismatch with app script.
desc: V0.3 Display 3-day weather forecast using OpenWeather One Call API 3.0.| load("render.star", "render") | ||
| load("schema.star", "schema") | ||
|
|
||
| OW_GEO_URL = "http://api.openweathermap.org/geo/1.0/zip" |
Contributor
There was a problem hiding this comment.
Use HTTPS for API requests.
Suggested change
| OW_GEO_URL = "http://api.openweathermap.org/geo/1.0/zip" | |
| OW_GEO_URL = "https://api.openweathermap.org/geo/1.0/zip" |
colin-is
commented
May 5, 2026
Contributor
Author
colin-is
left a comment
colin-is
left a comment
There was a problem hiding this comment.
Resolving all comments that were raised.
Member
|
it works ! thanks colin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to contribute a 3 day weather forecast app that uses OpenWeather's API. The number of requests is low enough to keep any user within the free tier.