Skip to content

Bug Fix: ABC News #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tavdog merged 1 commit into from
May 6, 2026
+10 −1
Merged

Bug Fix: ABC News #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/abcnews/abc_news.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ Applet: ABC News
Summary: Displays ABC News Headlines
Description: Displays headlines from ABC News Australia. Select the topic from the dropdown and it will display the latest 5 headlines.
Author: M0ntyP

v1.0
First release

v1.1
Added handling for when less than 5 stories in the feed
Comment on lines +6 to +11
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Remove the version history from the docstring. This information is typically managed via source control tags (e.g., Git) rather than manually maintained within the file. Additionally, the Starlark file should have the same base name as its containing directory (e.g., 'abcnews.star' instead of 'abc_news.star').

References
  1. The Starlark file containing the main() function should have the same base name as its containing directory.

"""

load("http.star", "http")
Expand All @@ -25,7 +31,10 @@ def main(config):
title = rss.query_all("//rss/channel/item/title")
description = []

for i in range(0, 5, 1):
# just in case less than 5 stories in the feed
feed_length = min(len(title), 5)

for i in range(0, feed_length, 1):
desc = title[i]
description.append(desc)
Comment on lines +34 to 39
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The loop and manual length calculation can be simplified using list.extend() with a slice. Starlark supports slicing, which is more idiomatic and automatically handles cases where the list contains fewer than the requested number of elements.

Suggested change
# just in case less than 5 stories in the feed
feed_length = min(len(title), 5)
for i in range(0, feed_length, 1):
desc = title[i]
description.append(desc)
description.extend(title[:5])


Expand Down