Repository navigation
feat(api): reject unpaired surrogates in protobuf string fields - #7102
Open
halibobo1205 wants to merge 1 commit into
Open
halibobo1205 wants to merge 1 commit into
halibobo1205 wants to merge 1 commit into
Conversation
halibobo1205
requested review from
0xbigapple,
317787106,
bladehan1 and
waynercheung
November 11, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Validates HTTP and JSON-RPC values assigned to protobuf
stringfields, rejecting unpaired surrogates. This aligns validation with the UTF-8 requirement enforced during gRPC/protobuf decoding.Why are these changes required?
Malformed Unicode is currently accepted and replaced with
?during protobuf serialization. This change validates it explicitly during request handling.Compatibility changes:
stringvalues now cause parsing or parameter errors instead of replacement.bytesfield conversions remain unchanged.This PR has been tested by:
Follow up
None.
Extra details
Only HTTP and JSON-RPC request handling changes. Transaction validation, transaction execution and block processing are unchanged.