Session change event#167
Open
0xEdouardEth wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Would it be possible to get a review on this PR and an estimate of when we could merge and release it? |
Contributor
|
@0xEdouardEth Which version of wallet I can test this feature ? I will test the android/ios/extension wallet and release it in the next two weeks. |
Contributor
Author
|
Thanks for your quick reply. You can test it with the latest version of the extension or Mobile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
metamask_accountsChangedbased account/status handling withwallet_sessionChangedbased handling. The reasonmetamask_accountsChangedevents were used before was because Multichain API methods did not returnaccountsordered by last selected.This is changing upstream so that Multichain API methods do return
accountsordered by last selected. This change allows us to get rid of our reliance onmetamask_accountsChangedand simplify our logic.This also makes it so that Tron connections granted outside of the Tron provider (i.e. missing
sessionProperties.tron_metamask_accountsChanged: true) will also properly work with our Tron wallet adapter. Previously they did not in the scenario above.See: MetaMask/metamask-extension#41068