feat(tokens): add support for sSTRK token and pools by 0xdevcollins · Pull Request #197 · trovesfi/troves-client

0xdevcollins · 2024-12-21T22:18:50Z

PR Fixes:

1 Added Dex pools for sSTRK listed on Ekubo and Nostra.
2 Integrated DeFi Spring rewards for sSTRK into Ekubo and Nostra codebase.

Resolves #190

Vercel website link

https://starkfarm-client-git-s-strk-deploy-ejembi-emmanuels-projects.vercel.app/

Checklist before requesting a review

I have performed a self-review of my code
I assure there is no similar/duplicate pull request regarding same issue
My PR passes all checks (build, lint, formatting, etc)

0xdevcollins · 2024-12-21T22:20:35Z

I get this error when I build

akiraonstarknet · 2024-12-23T08:54:47Z

@0xdevcollins there error could be bcz of improper env variables.
@EjembiEmmanuel can help

akiraonstarknet · 2024-12-23T09:53:39Z

@0xdevcollins
I dont think STRK Staking pool (sSTRK) by Nimbora is added. Even that needs to be added. Check endur protocol for reference.

Second, sSTRK pool on Vesu and Nostra (Lending/borrow) is not added.

EjembiEmmanuel · 2024-12-28T12:24:42Z

src/store/ekobu.store.ts

      'USDT',
      'ETH',
      'STRK',
+      'sSTRK/USDC',


This should be SSTRK not sSTRK

EjembiEmmanuel · 2024-12-28T12:24:59Z

src/store/ekobu.store.ts

      'ETH',
      'STRK',
+      'sSTRK/USDC',
+      'sSTRK/ETH',


Same as above

EjembiEmmanuel · 2024-12-28T12:25:13Z

src/store/ekobu.store.ts

      'STRK',
+      'sSTRK/USDC',
+      'sSTRK/ETH',
+      'sSTRK',


Same as above

EjembiEmmanuel · 2024-12-28T12:30:45Z

src/constants.ts

 export const TOKENS: TokenInfo[] = [
+  {
+    token: standariseAddress(
+      '0x0260c02fd6942c788b8905d2c1b98b5a98fffd2ec0dfb013aa4b148781e269b6',


The token contract address should be 0x0356f304b154d29d2a8fe22f1cb9107a9b564a733cf6b4cc47fd121ac1af90c9

EjembiEmmanuel · 2024-12-28T12:31:33Z

Please deploy your app on Vercel and provide the link in the description

EjembiEmmanuel · 2024-12-30T10:45:41Z

@0xdevcollins any progress?

0xdevcollins · 2024-12-31T14:06:04Z

@0xdevcollins any progress?

I update the Pr today

EjembiEmmanuel · 2024-12-31T14:20:18Z

Alright

EjembiEmmanuel · 2025-01-21T15:14:46Z

@0xdevcollins please deploy your app on Vercel and provide the link in the description

EjembiEmmanuel · 2025-01-23T13:43:50Z

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@0xdevcollins any progress with this?

0xdevcollins · 2025-01-25T01:35:56Z

https://starkfarm-client-dun.vercel.app

@0xdevcollins please deploy your app on Vercel and provide the link in the description

EjembiEmmanuel · 2025-01-25T10:54:03Z

https://starkfarm-client-dun.vercel.app

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@0xdevcollins it appears you deployed from your dev branch instead of your feature branch because I can't see your changes. Please redeploy from your feature branch.

EjembiEmmanuel · 2025-01-27T23:48:26Z

https://starkfarm-client-dun.vercel.app

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@0xdevcollins it appears you deployed from your dev branch instead of your feature branch because I can't see your changes. Please redeploy from your feature branch.

@0xdevcollins any update?

akiraonstarknet · 2025-02-02T17:41:42Z

src/constants.ts

  WBTC: '/zklend/icons/tokens/wbtc.svg?w=20',
  ETH: '/zklend/icons/tokens/eth.svg?w=20',
  STRK: '/zklend/icons/tokens/strk.svg?w=20',
+  SSTRK: '/zklend/icons/tokens/strk.svg?w=20',


Invalid sSTRK logo url. Also, its sSTRK, not SSTRK (The first s is small)

akiraonstarknet · 2025-02-02T17:41:53Z

src/constants.ts

+    token: standariseAddress(
+      '0x0356f304b154d29d2a8fe22f1cb9107a9b564a733cf6b4cc47fd121ac1af90c9',
+    ),
+    name: 'SSTRK',


its sSTRK, not SSTRK

akiraonstarknet · 2025-02-02T17:42:27Z

src/store/nostradex.store.ts

      const pools: PoolInfo[] = [];

-      const supportedPools = ['ETH-USDC', 'STRK-ETH', 'STRK-USDC', 'USDC-USDT'];
+      const supportedPools = [


This change has no impact on logic. sSTRK pool on nostra is shown even without this change.

akiraonstarknet · 2025-02-02T17:42:58Z

.codegpt/head

@@ -0,0 +1 @@
+095b1ce0-c1b8-4464-9692-ad6ed63effed


Unnecessary file. Please add to .codegpt to gitignore and refresh gitignore.

web3Gurung · 2025-02-14T09:40:06Z

@0xdevcollins you there?

EjembiEmmanuel · 2025-02-14T11:58:05Z

@0xdevcollins you there?

I don't think he's available. I will make the changes myself

web3Gurung · 2025-02-14T12:38:44Z

thank you, appreciate it!

…

On Fri, 14 Feb 2025 at 17:28, Oche ***@***.***> wrote: @0xdevcollins <https://github.com/0xdevcollins> you there? I don't think he's available. I will make the changes myself — Reply to this email directly, view it on GitHub <https://github.com/strkfarm/starkfarm-client/pull/197#issuecomment-2659148660>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARFSCGR3TKXHWDSCZRLNDXL2PXK6LAVCNFSM6AAAAABUBABFKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGE2DQNRWGA> . You are receiving this because you commented.Message ID: ***@***.***> [image: EjembiEmmanuel]*EjembiEmmanuel* left a comment (strkfarm/starkfarm-client#197) <https://github.com/strkfarm/starkfarm-client/pull/197#issuecomment-2659148660> @0xdevcollins <https://github.com/0xdevcollins> you there? I don't think he's available. I will make the changes myself — Reply to this email directly, view it on GitHub <https://github.com/strkfarm/starkfarm-client/pull/197#issuecomment-2659148660>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARFSCGR3TKXHWDSCZRLNDXL2PXK6LAVCNFSM6AAAAABUBABFKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGE2DQNRWGA> . You are receiving this because you commented.Message ID: ***@***.***>

feat(tokens): add support for sSTRK token and pools

071014c

akiraonstarknet requested a review from EjembiEmmanuel December 23, 2024 08:52

akiraonstarknet self-requested a review December 23, 2024 09:56

EjembiEmmanuel requested changes Dec 28, 2024

View reviewed changes

Merge branch 'strkfarm:dev' into feat/Add-sSTRK-DEX-pools

b7d1559

0xdevcollins and others added 3 commits December 31, 2024 16:34

fix: correct token name from 'sSTRK' to 'SSTRK' throughout the codebase

03e4fcc

Merge branch 'dev' into feat/Add-sSTRK-DEX-pools

78a0c62

add sSTRK to ekubo store

2156c51

akiraonstarknet requested changes Feb 2, 2025

View reviewed changes

feat: implement requested changes

28750a0

EjembiEmmanuel requested review from EjembiEmmanuel and akiraonstarknet February 14, 2025 12:33

EjembiEmmanuel approved these changes Feb 14, 2025

View reviewed changes

feat: add nimbora sSTRK

f846067

EjembiEmmanuel added 2 commits February 24, 2025 18:09

feat: add sSTRK to nostra

e84ff8b

feat: remove nimbora store and sSTRK pools

30eb2a6

akiraonstarknet approved these changes Mar 4, 2025

View reviewed changes

akiraonstarknet merged commit 056c473 into trovesfi:dev Mar 4, 2025
1 of 2 checks passed

		@@ -0,0 +1 @@
		095b1ce0-c1b8-4464-9692-ad6ed63effed No newline at end of file

Conversation

0xdevcollins commented Dec 21, 2024 • edited by EjembiEmmanuel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Fixes:

Vercel website link

Checklist before requesting a review

Uh oh!

0xdevcollins commented Dec 21, 2024

Uh oh!

akiraonstarknet commented Dec 23, 2024

Uh oh!

akiraonstarknet commented Dec 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EjembiEmmanuel commented Dec 28, 2024

Uh oh!

EjembiEmmanuel commented Dec 30, 2024

Uh oh!

0xdevcollins commented Dec 31, 2024

Uh oh!

EjembiEmmanuel commented Dec 31, 2024

Uh oh!

EjembiEmmanuel commented Jan 21, 2025

Uh oh!

EjembiEmmanuel commented Jan 23, 2025

Uh oh!

0xdevcollins commented Jan 25, 2025

Uh oh!

EjembiEmmanuel commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EjembiEmmanuel commented Jan 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

web3Gurung commented Feb 14, 2025

Uh oh!

EjembiEmmanuel commented Feb 14, 2025

Uh oh!

web3Gurung commented Feb 14, 2025 via email

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

0xdevcollins commented Dec 21, 2024 •

edited by EjembiEmmanuel

Loading

EjembiEmmanuel commented Jan 25, 2025 •

edited

Loading