Make MeTTa runner not read config dir by default#1020
Merged
vsbogd merged 4 commits intotrueagi-io:mainfrom Sep 9, 2025
Merged
Make MeTTa runner not read config dir by default#1020vsbogd merged 4 commits intotrueagi-io:mainfrom
vsbogd merged 4 commits intotrueagi-io:mainfrom
Conversation
It happens in unit tests which are the part of the Rust doc strings.
vsbogd
commented
Sep 3, 2025
| # except the case when _metta is set via get_agent_atom with parent MeTTa | ||
| if self._include_paths is not None: | ||
| env_builder = Environment.custom_env(include_paths=self._include_paths) | ||
| env_builder = Environment.custom_env(include_paths=self._include_paths, config_dir="") |
Collaborator
Author
There was a problem hiding this comment.
@Necr0x0Der, @besSveta I am not sure if agent should read configuration from file system or not, my opinion that probably not, but I reproduced previous behavior.
vsbogd
changed the title
DaddyWesker
approved these changes
Sep 3, 2025
besSveta
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1016 and expected to resolve nightly build random failures. Default behavior of
Environmentis changed:exts/agents.pycode is changed to read configuration from default configuration directoryEnvBuilder::set_no_config_diris removed andEnvBuilder::set_default_config_diris added instead. In Python API the default config dir is encoded as empty string. At first I was going to writeEnvBuilder::default_config_dir()method to return the default config dir and useEvnBuilder::set_config_dirto set it. But asEnvBuilder::default_config_dir()call can fail the error processing makes callers code ugly (not mentioning passing resulting path to the caller via C API). Thus I decided to keepEnvBuilder::set_default_config_dir()method instead.