Merged
Conversation
write_to works incorrectly with python3 -m build in isolated environment. setuptools scm recommends replace it by version_file configuration setting. To use version_file we need to upgrade setuptools_scm to 8.x and stop supporting Python 3.7 because they are not compatible.
conanfile.py has another default path for generators output. conanfile.txt puts generated files into current directory, conanfile.py puts them into ./build/<config>/generators directory
DaddyWesker
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #871 the path to the
conan_toolchain.cmakehas changed. Fix it to make release work.Remove support for Python 3.7 as it also breaks distribution package build.