Add E2E testing using KUTTL and Kind. #123

ramantehlan · 2025-06-04T12:02:46Z

Description

This PR add End-to-End (E2E) testing for Elasti using KUTTL (KUbernetes Test TooL). This is to validate Elasti's core functionalities in a realistic Kubernetes environment.

Type of change

Please delete options that are not relevant.

Adding testing suit.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Fully tested locally

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
A PR is open to update the helm chart (link)[https://github.com/truefoundry/elasti/tree/main/charts/elasti] if applicable
I have updated the CHANGELOG.md file with the changes I made

coderabbitai · 2025-06-04T12:02:53Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch rt-test-e2e
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…e chart for e2e tests

…to use Makefile commands

…make, update workflow

.github/workflows/e2e-kuttl-test.yaml

shubhamrai1993 · 2025-06-12T05:07:18Z

.github/workflows/e2e-kuttl-test.yaml

+          kubectl cluster-info
+          kubectl get nodes
+
+      - name: Build and push images


why not use this approach for setting up the local registry and kind? we won't need the docker registry then

https://github.com/helm/kind-action#configuring-local-registry

DEVELOPMENT.md

operator/Dockerfile

shubhamrai1993 · 2025-06-12T05:18:53Z

tests/e2e/kind-config.yaml

+nodes:
+- role: control-plane
+  extraPortMappings:
+  - containerPort: 30000


why these port configurations for control-plane are needed?

This is to auto expose some important ports for Ingress, Prometheus etc. This is still in testing.

It will essentially eliminate the need to port-forward those services.

shubhamrai1993 · 2025-06-12T05:35:44Z

tests/e2e/Makefile

+	@echo "Setting up Istio..."
+	@if ! command -v istioctl &> /dev/null; then \
+		echo "istioctl not found, installing..."; \
+		curl -L https://istio.io/downloadIstio | ISTIO_VERSION=1.20.0 sh -; \


lets use 1.25

actually this installed 1.16 on local

shubhamrai1993 · 2025-06-12T05:48:11Z

tests/e2e/Makefile

+	@echo "Elasti Operator installed successfully."
+
+# Setup Prometheus for metrics collection
+apply-prometheus:


lets add versions for each of these chart installations

shubhamrai1993 · 2025-06-12T06:45:20Z

tests/e2e/manifest/target-deployment.yaml

+metadata:
+  name: target-deployment-ingress
+  annotations:
+    nginx.ingress.kubernetes.io/rewrite-target: /$2


these annotations shouldn't be needed

Will remove this, as discussed, later we can have separate tests for Nginx and Istio.

tests/e2e/Makefile

shubhamrai1993 · 2025-06-12T07:04:59Z

tests/e2e/Makefile

+.PHONY: all kind-up kind-down e2e-test apply-deps traffic
+
+setup: start-registry kind-up apply-deps
+all: setup e2e-test


lets add a teardown-all step as well

shubhamrai1993 · 2025-06-12T07:34:38Z

tests/e2e/Makefile

+	@echo "Setting up Istio..."
+	@if ! command -v istioctl &> /dev/null; then \
+		echo "istioctl not found, installing..."; \
+		curl -L https://istio.io/downloadIstio | ISTIO_VERSION=1.20.0 sh -; \


actually this installed 1.16 on local

tests/e2e/Makefile

…eview comments | Minor documentation update

test: initial commit for e2e testing using KUTTL and Kind

26493a4

ramantehlan added 11 commits June 4, 2025 21:37

fix: fix minor markdown syntax issues

2489748

feat: add stop registry in root Makefile

1d79022

feat: add support for kind-registry, add it to kind-config, add uniqu…

f179f29

…e chart for e2e tests

e2e tests: example-tests working | restructure the test of repo

b3a7846

e2e tests: fix tests | add github workflow

414de61

e2e tests: add istio gateway to test

3485c9b

e2e tests: add keda, update services

42c1b91

e2e tests: fix keda ready check in makefile

e725a67

e2e tests: fix keda ready check in makefile

51430e4

e2e tests: update readme for running e2e tests, update github action …

9917f43

…to use Makefile commands

e2e tests: fix target-deployment issue, add port forward commands to …

b17c11c

…make, update workflow

shubhamrai1993 reviewed Jun 12, 2025

View reviewed changes

e2e tests: update make all to run everything end to end

b09ce43

shubhamrai1993 reviewed Jun 12, 2025

View reviewed changes

e2e tests: prom scraping of istio gateway and sidecar working | fix r…

8688285

…eview comments | Minor documentation update

Add E2E testing using KUTTL and Kind. #123

Are you sure you want to change the base?

Add E2E testing using KUTTL and Kind. #123

Uh oh!

Conversation

ramantehlan commented Jun 4, 2025

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

coderabbitai bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Jun 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)