Skip to content

feat: additional nodepool resource with flex-start type support - #44

Open
Ujjwal048 wants to merge 5 commits into
mainfrom
feat/additional-nodepool
Open

feat: additional nodepool resource with flex-start type support#44
Ujjwal048 wants to merge 5 commits into
mainfrom
feat/additional-nodepool

Conversation

@Ujjwal048

@Ujjwal048 Ujjwal048 commented Jul 30, 2026

Copy link
Copy Markdown

Note

Medium Risk
Changes GKE node pool provisioning and compute/network tagging on live clusters; misconfiguration could affect capacity, scheduling (taints/GPU), or firewall rules tied to tags.

Overview
Adds a new additional_node_pools input (map, default {}) and a google-beta google_container_node_pool.additional_pools resource so callers can declare extra GKE node pools beyond the built-in control-plane and critical pools. Pools are only created when use_existing_cluster is false.

Each pool entry can tune machine/disk settings, autoscaling vs fixed node_count, taints/labels, optional GPUs (including sharing config), max_pods_per_node, node_locations, queued provisioning, and reservation affinity. Flex-start pools set flex_start, default max_run_duration to 7 days when omitted, force NO_RESERVATION, and skip preemptible/spot.

Locals merge per-pool resource_labels and network_tags (with module network_tags) for node metadata and firewall tagging. control_plane_pool_config and critical_pool_config gain optional network_tags, appended to their existing network tag lists.

Reviewed by Cursor Bugbot for commit 7fe38cc. Bugbot is set up for automated code reviews on this repo. Configure here.

@Ujjwal048 Ujjwal048 changed the title add: additional nodepool resource with flex-start type support as well add: additional nodepool resource with flex-start type support Jul 30, 2026
@Ujjwal048 Ujjwal048 changed the title add: additional nodepool resource with flex-start type support feat: additional nodepool resource with flex-start type support Jul 30, 2026
Comment thread gke.tf
@Ujjwal048
Ujjwal048 force-pushed the feat/additional-nodepool branch from 1db1769 to fb71db7 Compare July 30, 2026 09:20
Comment thread gke.tf
@Ujjwal048
Ujjwal048 force-pushed the feat/additional-nodepool branch from fb71db7 to 4a118e3 Compare July 30, 2026 09:28

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4a118e3. Configure here.

Comment thread gke.tf
@Ujjwal048
Ujjwal048 force-pushed the feat/additional-nodepool branch from 4a118e3 to 917d2a4 Compare July 30, 2026 09:59
Comment thread variables.tf Outdated
Comment thread gke.tf Outdated
dunefro
dunefro previously approved these changes Jul 30, 2026
Comment thread locals.tf Outdated
@Ujjwal048
Ujjwal048 force-pushed the feat/additional-nodepool branch from 9ad6a4a to a2e34fa Compare July 30, 2026 12:38
@Ujjwal048
Ujjwal048 force-pushed the feat/additional-nodepool branch from 4a161e4 to c90497e Compare July 30, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants