feat: additional nodepool resource with flex-start type support - #44
Open
Ujjwal048 wants to merge 5 commits into
Open
feat: additional nodepool resource with flex-start type support#44Ujjwal048 wants to merge 5 commits into
Ujjwal048 wants to merge 5 commits into
Conversation
Ujjwal048
force-pushed
the
feat/additional-nodepool
branch
from
July 30, 2026 09:20
1db1769 to
fb71db7
Compare
Ujjwal048
force-pushed
the
feat/additional-nodepool
branch
from
July 30, 2026 09:28
fb71db7 to
4a118e3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4a118e3. Configure here.
Ujjwal048
force-pushed
the
feat/additional-nodepool
branch
from
July 30, 2026 09:59
4a118e3 to
917d2a4
Compare
dunefro
reviewed
Jul 30, 2026
dunefro
reviewed
Jul 30, 2026
dunefro
previously approved these changes
Jul 30, 2026
dunefro
reviewed
Jul 30, 2026
Ujjwal048
force-pushed
the
feat/additional-nodepool
branch
from
July 30, 2026 12:38
9ad6a4a to
a2e34fa
Compare
Ujjwal048
force-pushed
the
feat/additional-nodepool
branch
from
July 30, 2026 12:42
4a161e4 to
c90497e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes GKE node pool provisioning and compute/network tagging on live clusters; misconfiguration could affect capacity, scheduling (taints/GPU), or firewall rules tied to tags.
Overview
Adds a new
additional_node_poolsinput (map, default{}) and agoogle-betagoogle_container_node_pool.additional_poolsresource so callers can declare extra GKE node pools beyond the built-in control-plane and critical pools. Pools are only created whenuse_existing_clusteris false.Each pool entry can tune machine/disk settings, autoscaling vs fixed
node_count, taints/labels, optional GPUs (including sharing config),max_pods_per_node,node_locations, queued provisioning, and reservation affinity. Flex-start pools setflex_start, defaultmax_run_durationto 7 days when omitted, forceNO_RESERVATION, and skip preemptible/spot.Locals merge per-pool
resource_labelsandnetwork_tags(with modulenetwork_tags) for node metadata and firewall tagging.control_plane_pool_configandcritical_pool_configgain optionalnetwork_tags, appended to their existing network tag lists.Reviewed by Cursor Bugbot for commit 7fe38cc. Bugbot is set up for automated code reviews on this repo. Configure here.