NAS-138594 / 26.04 / Add client support for SCRAM-SHA512 auth for API keys #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
add-scram-auth
branch
3 times, most recently
from
12ec52e to
cfca481
Compare
This commit adds the ability for our API client and midclt command to perform SCRAM-SHA512 authentication to a TrueNAS server. This new authentication mechanism provides replay resistance and detection of case where the remote server is (possibly maliciously) granting us access without actually having access to either the API key's hash or keys derived from said hash. The new authentication mechanism is only attempted if the TrueNAS server reports that it supports the mechanism.
anodos325
force-pushed
the
add-scram-auth
branch
from
cfca481 to
0ff9448
Compare
bugclerk
changed the title
billohanlon
reviewed
Nov 18, 2025
|
|
||
|
|
||
| class ClientFinalMessage: | ||
| __rfc_str = '<UNITIALIZED>' |
There was a problem hiding this comment.
Typo for uninitialized? Is the value important?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability for our API client and midclt command to perform SCRAM-SHA512 authentication to a TrueNAS server. This new authentication mechanism provides replay resistance and detection of case where the remote server is (possibly maliciously) granting us access without actually having access to either the API key's hash or keys derived from said hash. The new authentication mechanism is only attempted if the TrueNAS server reports that it supports the mechanism.