Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Reactive Resume TrueNAS app to v5.1.0 and removes the no-longer-required Chromedp “print server” sidecar, aligning the app with upstream changes (issue #4948).
Changes:
- Removed the Chromedp container and its related environment variables and questions UI entries.
- Updated the Reactive Resume image/app versions to v5.1.0 / 1.0.20.
- Updated the Reactive Resume healthcheck to use the
httpprobe.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ix-dev/community/reactive-resume/templates/docker-compose.yaml | Removes Chromedp container wiring and updates the resume container healthcheck/dependencies. |
| ix-dev/community/reactive-resume/questions.yaml | Removes Chromedp from selectable container lists in the UI schema. |
| ix-dev/community/reactive-resume/ix_values.yaml | Bumps image tag and removes Chromedp image/container-name constants. |
| ix-dev/community/reactive-resume/app.yaml | Bumps app version and removes Chromedp run_as_context entry. |
Comments suppressed due to low confidence (1)
ix-dev/community/reactive-resume/ix_values.yaml:21
- After removing the chromedp container/image,
constsstill containschromedp_port. It’s now unused in this app and can be removed to avoid carrying dead configuration (and to prevent future confusion about a required print-service dependency).
consts:
reactive_resume_container_name: reactive-resume
postgres_container_name: postgres
perms_container_name: permissions
db_user: reactive_resume
db_name: reactive_resume
chromedp_port: 9222
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
ix-dev/community/reactive-resume/ix_values.yaml:21
consts.chromedp_portremains defined even though the Chromedp/print-server container and all references were removed in this PR. This constant now appears unused and can be removed to avoid confusion and reduce dead configuration surface.
postgres_container_name: postgres
perms_container_name: permissions
db_user: reactive_resume
db_name: reactive_resume
chromedp_port: 9222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4948