Skip to content

reactive-resume: remove print server#4950

Draft
stavros-k wants to merge 5 commits intomasterfrom
reactive-resume
Draft

reactive-resume: remove print server#4950
stavros-k wants to merge 5 commits intomasterfrom
reactive-resume

Conversation

@stavros-k
Copy link
Copy Markdown
Contributor

Closes #4948

@stavros-k stavros-k changed the title Reactive resume reactive-resume: remove print server May 7, 2026
@stavros-k stavros-k requested a review from Copilot May 7, 2026 16:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Reactive Resume TrueNAS app to v5.1.0 and removes the no-longer-required Chromedp “print server” sidecar, aligning the app with upstream changes (issue #4948).

Changes:

  • Removed the Chromedp container and its related environment variables and questions UI entries.
  • Updated the Reactive Resume image/app versions to v5.1.0 / 1.0.20.
  • Updated the Reactive Resume healthcheck to use the http probe.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
ix-dev/community/reactive-resume/templates/docker-compose.yaml Removes Chromedp container wiring and updates the resume container healthcheck/dependencies.
ix-dev/community/reactive-resume/questions.yaml Removes Chromedp from selectable container lists in the UI schema.
ix-dev/community/reactive-resume/ix_values.yaml Bumps image tag and removes Chromedp image/container-name constants.
ix-dev/community/reactive-resume/app.yaml Bumps app version and removes Chromedp run_as_context entry.
Comments suppressed due to low confidence (1)

ix-dev/community/reactive-resume/ix_values.yaml:21

  • After removing the chromedp container/image, consts still contains chromedp_port. It’s now unused in this app and can be removed to avoid carrying dead configuration (and to prevent future confusion about a required print-service dependency).
consts:
  reactive_resume_container_name: reactive-resume
  postgres_container_name: postgres
  perms_container_name: permissions
  db_user: reactive_resume
  db_name: reactive_resume
  chromedp_port: 9222

Comment thread ix-dev/community/reactive-resume/templates/docker-compose.yaml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

ix-dev/community/reactive-resume/ix_values.yaml:21

  • consts.chromedp_port remains defined even though the Chromedp/print-server container and all references were removed in this PR. This constant now appears unused and can be removed to avoid confusion and reduce dead configuration surface.
  postgres_container_name: postgres
  perms_container_name: permissions
  db_user: reactive_resume
  db_name: reactive_resume
  chromedp_port: 9222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Remove print server and update healthcheck for reactive-resume

2 participants