Se/retry failed deletes#4
Merged
mrstux merged 3 commits intoadd-truenas-storage-driverfrom May 28, 2025
Merged
Conversation
added 3 commits
May 28, 2025 03:34
…ates shares error handling increased, now deletes a share rather than de-activatinga and relying on deleteDatsetRecursive to delete the share
…Name the intention is that if multiple servers in a cluster attempt to mount the same volume snapshot, which is a legitimate scenario, then they should all succeed
we sometimes see spurious EBUSY errors when deleting datasets from the server, the suspicion is that the dataset has not quiesced yet after we have finished using, deactivating, and unsharing etc, thus if we try again it should delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when deleting remote zvols, we sometimes see a busy error after they've been de-activated. This is probably a race condition. We now retry.
Additionally, a potential issue with remote snapshot temp names when the same snapshot is mounted on different members of the same cluster has been potentially resolved.