Closed
Conversation
We round up volume sizes in many cases to align it with underlying storage extents. So when comparing sizes, allow for some margin so we don't fail migrations that are just slightly larger due to that rounding. Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Sponsored-by: https://webdock.io
Adds assigning an err to the result of a transaction where it was forgotten. Signed-off-by: karo <karolin.kostial@gmail.com>
… the package of the same name Signed-off-by: karo <karolin.kostial@gmail.com>
…lide with the package of the same name Signed-off-by: karo <karolin.kostial@gmail.com>
…collide with the package name Signed-off-by: karo <karolin.kostial@gmail.com>
…collide with the package name Signed-off-by: karo <karolin.kostial@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Add the missing iota case with an explicit comment about it being ignored. Signed-off-by: karo <karolin.kostial@gmail.com>
… iota constants Moves the external return into the switch statements, so that the switch over the iota covers all the cases internally. Signed-off-by: karo <karolin.kostial@gmail.com>
…overs all iota constants Moves the external return into the switch statements, so that the switch over the iota covers all the cases internally. Signed-off-by: karo <karolin.kostial@gmail.com>
Adds more tests for verifying the implementation of the error interface for the ErrorList type. Signed-off-by: karo <karolin.kostial@gmail.com>
Refactors the implementation of the error interface on ErrorList to improve readability. Signed-off-by: karo <karolin.kostial@gmail.com>
Refactors ErrorList to be a struct containing a slice of Errors. This is done so that all functions declared on ErrorList can more easily have the same receiver type (a pointer) without the code getting too unreadable. Signed-off-by: karo <karolin.kostial@gmail.com>
Refactors Error to be renamed to configurationError so it can be private. Signed-off-by: karo <karolin.kostial@gmail.com>
Removes the redundant map size initialization to 0 as it is equivalent to not specifying a size. Signed-off-by: karo <karolin.kostial@gmail.com>
Removes the redundant map size initialization to 0 as it is equivalent to not specifying a size. Signed-off-by: karo <karolin.kostial@gmail.com>
Removes the redundant map size initialization to 0 as it is equivalent to not specifying a size. Signed-off-by: karo <karolin.kostial@gmail.com>
Removes unused code in internal/dnsutil. Signed-off-by: karo <karolin.kostial@gmail.com>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Lucas Bremgartner <lucas.bremgartner@futurfusion.io>
Refactors the DHCPValidIP condition checks. The way it was written had a redundant else branch to check the `inSubnet` variable. Signed-off-by: karo <karolin.kostial@gmail.com>
Renames the function instanceActionToOptype to fix a typo. Also move the default case into the switch. Signed-off-by: karo <karolin.kostial@gmail.com>
Adds tests for the ContainsIp and String methods on the iprange.Range struct type. Signed-off-by: karo <karolin.kostial@gmail.com>
Signed-off-by: Kim Ton <kimton@utexas.edu>
Signed-off-by: Kim Ton <kimton@utexas.edu>
Signed-off-by: Kim Ton <kimton@utexas.edu>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
And use unix conn directly. Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Jeremys Ross <joseveal9@gmail.com>
Signed-off-by: Jeremys Ross <joseveal9@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
…ates shares error handling increased, now deletes a share rather than de-activatinga and relying on deleteDatsetRecursive to delete the share Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
…Name the intention is that if multiple servers in a cluster attempt to mount the same volume snapshot, which is a legitimate scenario, then they should all succeed Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
we sometimes see spurious EBUSY errors when deleting datasets from the server, the suspicion is that the dataset has not quiesced yet after we have finished using, deactivating, and unsharing etc, thus if we try again it should delete. Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: David Bockelman <davidbockelman@utexas.edu>
Signed-off-by: David Bockelman <davidbockelman@utexas.edu>
Signed-off-by: David Bockelman <davidbockelman@utexas.edu>
Signed-off-by: David Bockelman <davidbockelman@utexas.edu>
Signed-off-by: David Bockelman <davidbockelman@utexas.edu>
NFS4v2 supports user.xattr, and can be used with Incus via the dir driver, but image unpacking will fail when the container image uses non-user xattrs such as security.xattr This fix will skip extraction of security.xattrs when extracting to an NFS hosted directory The fix is not specific to the dir driver, and could benefit a future NFS driver too. Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
…tions Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this encapsulated the NFS based driver.