NAS-135620 / 25.10 / Simplify middleware audit startup #16371
+97
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
simplify-audit-startup
branch
2 times, most recently
from
4378919 to
9671e0e
Compare
Delay certain expensive parts of middlewared auditing startup (an initial scan for file changes and removing unnecessary refreservations on old audit datasets) until after the system READY event, and only perform it on first boot after upgrade or fresh install. This commit also removes the AuditSetupAlertClass. It could only be called during the first boot for a boot environment and would never be dismissed. Removal decreases complexity of operations during system ready events on first boot.
anodos325
force-pushed
the
simplify-audit-startup
branch
from
6e32007 to
0794429
Compare
bugclerk
changed the title
yocalebo
reviewed
Apr 29, 2025
yocalebo
reviewed
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay certain expensive parts of middlewared auditing startup (an initial scan for file changes and removing unnecessary refreservations on old audit datasets) until after the system READY event, and only perform it on first boot after upgrade or fresh install.