Skip to content

NAS-139069 Wipe disk writes ASCII 0 instead of bytes 0 #17898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryd994 wants to merge 1 commit into from
+2 −2
Closed

NAS-139069 Wipe disk writes ASCII 0 instead of bytes 0 #17898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/middlewared/middlewared/plugins/disk_/wipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _wipe_impl(self, job, dev, mode, event):
# no reason to write more than 1MB at a time
# or kernel will break them into smaller chunks
if mode in ('QUICK', 'FULL'):
to_write = b'0' * CHUNK
to_write = b'\0' * CHUNK
else:
to_write = os.urandom(CHUNK)

Expand Down
2 changes: 1 addition & 1 deletion src/middlewared/middlewared/plugins/pool_/expand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ async def expand_partition(self, part_data):
def wipe_label():
with open(os.path.join('/dev', part_data['disk']), 'r+b') as f:
f.seek(wipe_start)
f.write(b'0' * wipe_size)
f.write(b'\0' * wipe_size)

await self.middleware.run_in_thread(wipe_label)

Expand Down