NAS-140294 / 27.0.0-BETA.1 / Fix alert deserialization crash on upgrade#18455
Open
NAS-140294 / 27.0.0-BETA.1 / Fix alert deserialization crash on upgrade#18455
Conversation
This commit fixes an issue where middleware won't start when a system is upgraded to latest nightlies because the recent alerts mypy refactor changed alert args format (moving fields from `key` into required dataclass fields in `args`). Pre-existing alerts in `system_alert` have the old format and crash during deserialization at startup. The migration deletes the affected rows; all are ephemeral and regenerated by their alert sources within 60 seconds.
Contributor
bugclerk
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where middleware won't start when a system is upgraded to latest nightlies because the recent alerts mypy refactor changed alert args format (moving fields from
keyinto required dataclass fields inargs). Pre-existing alerts insystem_alerthave the old format and crash during deserialization at startup. The migration deletes the affected rows; all are ephemeral and regenerated by their alert sources within 60 seconds.