Add support for sntasmedia interface type (fixes #97) #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #97 by adding support for the
sntasmediainterface type used by USB NVMe devices with ASMedia controllers, such as the Samsung Portable SSD T7.Problem
When scanning devices with
DeviceList(), the library was throwing aValueErrorfor devices using thesntasmediainterface:This occurred because smartctl 7.5+ reports
sntasmediaas the interface type for USB NVMe devices with ASMedia controllers, but this interface type was not recognized by pySMART.Solution
Added
sntasmediato thesmartctl_type_dictinpySMART/utils.py, mapping it tonvmesince these devices are NVMe-based:This minimal change ensures that devices with the
sntasmediainterface are properly recognized and treated as NVMe devices for all smartctl operations.Testing
tests/dataset/singletests/sntasmedia_nvme_0_issue_97/using the actual smartctl output from the issue reportAffected Devices
This fix enables support for:
sntasmediainterface typeOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.