fix exiting loop early if /sys/block/${dev}/ has boot section#116
Open
ngicks wants to merge 1 commit intotruenas:masterfrom
Open
fix exiting loop early if /sys/block/${dev}/ has boot section#116ngicks wants to merge 1 commit intotruenas:masterfrom
/sys/block/${dev}/ has boot section#116ngicks wants to merge 1 commit intotruenas:masterfrom
Conversation
ngicks
changed the title
/sys/block/${dev}/ has boot section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to install the truenas on mmcblk0.
It fails for
Failed to find partition number 2 on mmcblk0.I noticed that
/sys/block/mmcblk0hasmmcblk0boot0andmmcblk0boot1in there.The script was trying to read
/sys/block/mmcblk0/mmcblk0boot0/partitionand/sys/block/mmcblk0/mmcblk0boot1/partition(if I remember correctly. I was playing around truenas as work and this is my free time OSS contribution) which are nonexistent. That was causing early loop exit.I applied this fix by manually editing the script in bootable USB's overlay fs.
And it worked for me and now I think I need to let everyone know about this.