NAS-135256 / 25.10 / Simplify Services page #11920
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 83.67% 83.65% -0.03%
==========================================
Files 1687 1687
Lines 59681 59665 -16
Branches 6613 6610 -3
==========================================
- Hits 49941 49911 -30
- Misses 9740 9754 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
undsoft
requested changes
Apr 25, 2025
There was a problem hiding this comment.
- Let's swap places between Play and Edit buttons.
- Can we have Stopped as gray instead of Red?
- Rename
NFS/SMB SessionstoView Sessions. - Rename
Audit LogstoView Logs. - Add underline for those links.
- Add space between links and action buttons.
- Last column doesn't look too good on some smaller resolutions – it starts to collapse too early.
undsoft
approved these changes
Apr 30, 2025
| > | ||
| <ix-icon [name]="action.iconName"></ix-icon> | ||
| </button> | ||
| @if (action?.dynamicText && (action.dynamicText(row()) | async); as dynamicText) { |
There was a problem hiding this comment.
At this point, it's just better to use a custom cell within services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: see ticket.
Result:
Screen.Recording.2025-04-24.at.12.37.15.mov