Skip to content

NAS-135360 / 25.10 / Use new editable fields in user form #11923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

Changes:

  • Use new editable fields in user form

Testing:

Check user form on Users (WIP)

@bugclerk bugclerk changed the title Use new editable fields in user form NAS-135360 / 25.10 / Use new editable fields in user form Apr 24, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 27.02703% with 27 lines in your changes missing coverage. Please review.

Project coverage is 83.53%. Comparing base (1265dc1) to head (bf636db).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ls-section/additional-details-section.component.ts 23.33% 23 Missing ⚠️
...entials/new-users/user-form/user-form.component.ts 0.00% 3 Missing ⚠️
...access-section/allowed-access-section.component.ts 66.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (27.02%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11923      +/-   ##
==========================================
- Coverage   83.56%   83.53%   -0.04%     
==========================================
  Files        1685     1685              
  Lines       59514    59547      +33     
  Branches     6587     6589       +2     
==========================================
+ Hits        49733    49740       +7     
- Misses       9781     9807      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form looks cool.
I noticed a couple of issues:

  1. Form counts invalid (submit is disabled) until I pass through all the Additional Details block.
Screen.Recording.2025-04-25.at.08.32.29.mov
  1. Selecting Shell leads to the infinite loading input.
Screen.Recording.2025-04-25.at.08.34.16.mov
  1. I can open edit mode but can't exit it if I don't want to change any value, is that OK? (or if I changed the value I need to open another field for editing to close the previous)
Screen.Recording.2025-04-25.at.08.36.50.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants