Skip to content

NAS-135388 / 25.10 / A banner for STIG disappeared if the system rebooted #11937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Apr 29, 2025

Testing:

Original issue was reproducible by setting login banner in Advanced Settings, logging out and breaking websocket connection.
The expectation is that login banner is still shown after WS connection reestablishes.

For connection to break you can just wait for bit on login page.

@undsoft undsoft requested a review from a team as a code owner April 29, 2025 11:49
@undsoft undsoft requested review from RehanY147 and removed request for a team April 29, 2025 11:49
@bugclerk bugclerk changed the title NAS-135388: A banner for STIG disappeared if the system rebooted NAS-135388 / 25.10 / A banner for STIG disappeared if the system rebooted Apr 29, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (bce4248) to head (dada1ad).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11937   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files        1685     1685           
  Lines       59550    59553    +3     
  Branches     6596     6596           
=======================================
+ Hits        49773    49776    +3     
  Misses       9777     9777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the banner now

@undsoft undsoft merged commit 310ea55 into master Apr 30, 2025
9 checks passed
@undsoft undsoft deleted the NAS-135388 branch April 30, 2025 06:58
@undsoft
Copy link
Collaborator Author

undsoft commented Apr 30, 2025

backport

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants