Skip to content

NAS-135491 / 25.10 / Allow specifying image OS for virt VMs in UI #11938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 2, 2025

Conversation

AlexKarpov98
Copy link
Contributor

Testing:
See ticket.

Quick preview:

Screen.Recording.2025-04-29.at.18.22.52.mov

Downstream

Affects Reasoning
Documentation New Field for ISO Volume

@AlexKarpov98 AlexKarpov98 self-assigned this Apr 29, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner April 29, 2025 15:33
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team April 29, 2025 15:33
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-135491: Allow specifying image OS for virt VMs in UI NAS-135491 / 25.10 / Allow specifying image OS for virt VMs in UI Apr 29, 2025
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (5c75981) to head (79c4875).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ms/components/ix-combobox/ix-combobox.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11938   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files        1685     1686    +1     
  Lines       59653    59685   +32     
  Branches     6626     6633    +7     
=======================================
+ Hits        49926    49955   +29     
- Misses       9727     9730    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) May 1, 2025 11:14
@AlexKarpov98 AlexKarpov98 merged commit 50c1db4 into master May 2, 2025
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-135491 branch May 2, 2025 09:14
@bugclerk
Copy link
Contributor

bugclerk commented May 2, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants