-
Notifications
You must be signed in to change notification settings - Fork 339
NAS-135491 / 25.10 / Allow specifying image OS for virt VMs in UI #11938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11938 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 1685 1686 +1
Lines 59653 59685 +32
Branches 6626 6633 +7
=======================================
+ Hits 49926 49955 +29
- Misses 9727 9730 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼
src/app/modules/forms/ix-forms/components/ix-combobox/ix-combobox.component.ts
Show resolved
Hide resolved
...es/instance-details/instance-general-info/instance-edit-form/instance-edit-form.component.ts
Show resolved
Hide resolved
src/app/pages/instances/components/instance-wizard/instance-wizard.component.ts
Outdated
Show resolved
Hide resolved
src/app/pages/instances/components/instance-wizard/instance-wizard.component.html
Outdated
Show resolved
Hide resolved
This PR has been merged and conversations have been locked. |
Testing:
See ticket.
Quick preview:
Screen.Recording.2025-04-29.at.18.22.52.mov
Downstream