fix: throws error if dir not found #3419
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1fcff0a.
rosecodym
reviewed
Oct 16, 2024
Comment on lines
+331
to
+334
| // Check if the directory exists | ||
| if _, err := os.Stat(gitDir); os.IsNotExist(err) { | ||
| return fmt.Errorf("directory does not exist: %s", gitDir) | ||
| } |
There was a problem hiding this comment.
I believe this change is the only one that's needed. With just it applied, this is the output I get:
trufflehog (remotes/origin/HEAD *) % ./trufflehog git file:///oops
🐷🔑🐷 TruffleHog. Unearth your secrets. 🐷🔑🐷
2024-10-16T16:14:08-04:00 info-0 trufflehog running source {"source_manager_worker_id": "hN9fy", "with_units": true}
2024-10-16T16:14:08-04:00 error trufflehog error running scan {"error": "engine failed to finish execution: fatal: directory does not exist: /oops"}
trufflehog (remotes/origin/HEAD *) % echo $?
1
Are you seeing something different?
There was a problem hiding this comment.
@rosecodym Thanks for the review, I have removed the code. Can you please check again?
Signed-off-by: Sahil Silare <[email protected]>
Signed-off-by: Sahil Silare <[email protected]>
Signed-off-by: Sahil Silare <[email protected]>
|
@kashifkhan0771 Can you please review this minor PR? Thanks! |
kashifkhan0771
approved these changes
Jun 24, 2025
rosecodym
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR relates to #3005 . If the directory is not found, the process returns an error message and exits.
Checklist:
make test-community)?make lintthis requires golangci-lint)?