Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: reduce false-positive secrets #3722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Azure: reduce false-positive secrets #3722

wants to merge 1 commit into from

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Dec 3, 2024 •
edited
Loading

Description:

This skips alpha-only and low-entropy secrets. It also has a few misc improvements discovered while testing.

e.g.,

✅ Found verified result 🐷🔑
Detector Type: Azure
Decoder Type: PLAIN
Raw result: {"clientSecret":"preferredTokenSigningKeyThumbprint",

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner December 3, 2024 00:25
@rgmz rgmz force-pushed the fix/azure_fp branch 3 times, most recently from cfdc88b to fcec1bb Compare December 6, 2024 14:13
@rgmz rgmz mentioned this pull request Dec 13, 2024
Merged
2 tasks
@rgmz rgmz force-pushed the fix/azure_fp branch 2 times, most recently from ed58238 to a9633cc Compare December 15, 2024 15:27
@rgmz rgmz force-pushed the fix/azure_fp branch 6 times, most recently from 7f0f452 to a7ac795 Compare January 13, 2025 21:31
@rgmz rgmz force-pushed the fix/azure_fp branch 2 times, most recently from 94ea476 to e225e19 Compare January 20, 2025 14:55
@rgmz rgmz force-pushed the fix/azure_fp branch 2 times, most recently from 696e176 to d101d21 Compare January 27, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rgmz