Add analysis info for GCP creds #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/detectors/gcp/gcp.go
Outdated
| @@ -113,6 +113,7 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result | |||
| "rotation_guide": "https://howtorotate.com/docs/tutorials/gcp/", | |||
| "project": creds.ProjectID, | |||
| }, | |||
| AnalysisInfo: map[string]string{"user": creds.ClientEmail}, | |||
There was a problem hiding this comment.
Usually this would be a service account. Maybe we should stick with gcp terminology and call it principal?
https://cloud.google.com/iam/docs/principal-identifiers
Also, what is this field for in the detector result?
There was a problem hiding this comment.
Good call. There is a type usually in the full key file. I'll add that if it exists. Otherwise the plan was to check both.
dustin-decker
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Explain the purpose of the PR.
Checklist:
make test-community)?make lintthis requires golangci-lint)?