[refactor] - base64 decoder #3762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
commented
Dec 11, 2024
| } | ||
|
|
||
| func appendB64Substring(data []byte, start, count int, substrings []string, endChars string) []string { | ||
| substring := bytes.TrimLeft(data[start:start+count], endChars) | ||
| if idx := bytes.IndexByte(bytes.TrimRight(substring, endChars), '='); idx != -1 { |
There was a problem hiding this comment.
The logic for handling = within the middle of a string has been preserved.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rosecodym
requested changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the base64 decoder. During the investigation of a client-reported CPU usage issue, profiling revealed that base64 decoding accounted for about ~6 seconds in a 30-second profile. The change required relatively low effort but delivers noticeable improvements.
Benchmarks
Checklist:
make test-community)?make lintthis requires golangci-lint)?