Enable Auth0 #3857
Merged
Enable Auth0 #3857
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
approved these changes
Jan 28, 2025
rgmz
reviewed
Jan 28, 2025
abmussani
reviewed
Jan 29, 2025
Comment on lines
40
to
41
| clientIdMatches := clientIdPat.FindAllStringSubmatch(dataStr, -1) | ||
| clientSecretMatches := clientSecretPat.FindAllStringSubmatch(dataStr, -1) |
There was a problem hiding this comment.
Why isn’t the uniqueness logic applied to both Id and Secret?
There was a problem hiding this comment.
Good point, each pattern should be unique
Co-authored-by: Richard Gomez <[email protected]>
kashifkhan0771
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, I think, we disabled auth0 because it was too noisy since the verify loop is buried in a 3 deep nested loop. This means a single domain could be matched multiple times in the same chunk.
Checklist:
make test-community)?make lintthis requires golangci-lint)?