feat: role management API & integration tests#131
Merged
Conversation
- Updated GrantRole and RevokeRole methods to utilize EthereumAddresses for better type safety. - Introduced AreMembersOf and ListRoleMembers methods for checking role membership and listing members with pagination. - Added EthereumAddressesToStrings utility function for converting EthereumAddress slices to string representations. - Updated documentation to reflect the new method names and functionalities.
- Introduced a new integration test for verifying the granting and revoking of the `system:network_writer` role. - Enhanced the ServerFixture to manage private keys for the manager and database owner. - Updated utility functions to improve transaction handling and assertions. - Refactored existing test code for better type safety and clarity.
…lient creation - Refactored integration tests to include the use of `kwilcrypto` for wallet management. - Updated client creation logic to ensure proper context handling and error checking. - Enhanced test setup by authorizing wallets for stream deployment across multiple test files. - Adjusted loop conditions in batch operations tests for inclusive iteration. - Improved overall type safety and clarity in test implementations.
outerlook
changed the title
- Introduced the `IRoleManagement.ListRoleMembers` method to list current members of a role with optional pagination. - Enhanced integration tests to verify the functionality of the new `ListRoleMembers` method, ensuring correct membership assertions after granting and revoking roles. - Improved type safety and clarity in test implementations related to role management.
Time Submission Status
|
MicBun
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AreMembersOfandListRoleMemberscontract calls, input/output structs, and interface updates.EthereumAddressesToStringshelper for safe slice conversion.docs/stream-permissions.md) with missingListRoleMembersbullet.role_management_test.gocovering grant / revoke / membership checks and permission gates.Related Problem
How Has This Been Tested?